]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: tipc: avoid possible garbage value
authorSu Hui <suhui@nfschina.com>
Thu, 12 Sep 2024 11:01:20 +0000 (19:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:32:31 +0000 (16:32 +0200)
commitb896bab4366a42ad45d3ae5bffe72c973a97594e
treee01ca10a0b075082b9d529067f7f475ffe49f5bf
parentd2dd99827dfde589bfe9f41ae8b162c29945c4f5
net: tipc: avoid possible garbage value

[ Upstream commit 99655a304e450baaae6b396cb942b9e47659d644 ]

Clang static checker (scan-build) warning:
net/tipc/bcast.c:305:4:
The expression is an uninitialized value. The computed value will also
be garbage [core.uninitialized.Assign]
  305 |                         (*cong_link_cnt)++;
      |                         ^~~~~~~~~~~~~~~~~~

tipc_rcast_xmit() will increase cong_link_cnt's value, but cong_link_cnt
is uninitialized. Although it won't really cause a problem, it's better
to fix it.

Fixes: dca4a17d24ee ("tipc: fix potential hanging after b/rcast changing")
Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Justin Stitt <justinstitt@google.com>
Link: https://patch.msgid.link/20240912110119.2025503-1-suhui@nfschina.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/tipc/bcast.c