]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
phy: stm32-usphyc: Fix off by one in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 9 Dec 2025 06:53:36 +0000 (09:53 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Jan 2026 10:18:41 +0000 (11:18 +0100)
commitb91c9f6bfb04e430adeeac7e7ebc9d80f9d72bad
tree29ee5f67139cef927d219ddde103d9db67628d5d
parentd50a9b7fd07296a1ab81c49ceba14cae3d31df86
phy: stm32-usphyc: Fix off by one in probe()

[ Upstream commit cabd25b57216ddc132efbcc31f972baa03aad15a ]

The "index" variable is used as an index into the usbphyc->phys[] array
which has usbphyc->nphys elements.  So if it is equal to usbphyc->nphys
then it is one element out of bounds.  The "index" comes from the
device tree so it's data that we trust and it's unlikely to be wrong,
however it's obviously still worth fixing the bug.  Change the > to >=.

Fixes: 94c358da3a05 ("phy: stm32: add support for STM32 USB PHY Controller (USBPHYC)")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Link: https://patch.msgid.link/aTfHcMJK1wFVnvEe@stanley.mountain
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/phy/st/phy-stm32-usbphyc.c