]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/{i915, xe}/display: duplicate gen2 irq/error init/reset in display irq
authorJani Nikula <jani.nikula@intel.com>
Mon, 17 Nov 2025 09:16:08 +0000 (11:16 +0200)
committerJani Nikula <jani.nikula@intel.com>
Wed, 19 Nov 2025 17:33:43 +0000 (19:33 +0200)
commitb9241d0ed9cefc7f9b9bb65533494d7776964d79
tree6964b786909085493afb1bcba7bbce9d3be62d2e
parent7e2d78535432e44f908c6c44f73828cfd9c12aee
drm/{i915, xe}/display: duplicate gen2 irq/error init/reset in display irq

Duplicate gen2_irq_reset(), gen2_assert_iir_is_zero(), gen2_irq_init(),
gen2_error_reset(), and gen2_error_init() in intel_display_irq.c.

This allows us to drop the duplicates from xe, and prepares for future
cleanups. Although duplication is undesirable in general, in this case
the local duplicates lead to a cleaner end result.

There's a slight wrinkle in gen2_assert_iir_is_zero(). We need to use
non-device based logging until we pass in struct intel_display in a
separate change.

v2:
- Keep xe compat stuff due to series reorder and rebase
- Keep the WARN as regular WARN
- Rename the functions in the same go

Suggested-by: Ville Syrjala <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/296d74731cce57ab7534c57969d3146294adda57.1763370931.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_display_irq.c
drivers/gpu/drm/xe/display/ext/i915_irq.c