]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netfilter: conntrack: helper: Replace -EEXIST by -EBUSY
authorPhil Sutter <phil@nwl.cc>
Mon, 18 Aug 2025 11:22:20 +0000 (13:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 9 Sep 2025 16:54:13 +0000 (18:54 +0200)
commitb936ec6aad648ec94215f8d5997e1acffed64f2d
treeaf4bebac562da5f689601b9b9fa83de38e8191ea
parentccbad4803225eafe0175d3cb19f0d8d73b504a94
netfilter: conntrack: helper: Replace -EEXIST by -EBUSY

[ Upstream commit 54416fd76770bd04fc3c501810e8d673550bab26 ]

The helper registration return value is passed-through by module_init
callbacks which modprobe confuses with the harmless -EEXIST returned
when trying to load an already loaded module.

Make sure modprobe fails so users notice their helper has not been
registered and won't work.

Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Fixes: 12f7a505331e ("netfilter: add user-space connection tracking helper infrastructure")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/netfilter/nf_conntrack_helper.c