]> git.ipfire.org Git - thirdparty/libvirt.git/commit
numatune: setting --mode does not work well
authorErik Skultety <eskultet@redhat.com>
Fri, 22 Aug 2014 14:05:37 +0000 (16:05 +0200)
committerJán Tomko <jtomko@redhat.com>
Fri, 22 Aug 2014 14:34:23 +0000 (16:34 +0200)
commitb9ff7393bca5df988e182b45ede34c636b0ae90d
treeaef8083601018b2a85df901cf7124023c0cc5d36
parent36a0993a15ca43298073f96081176c612cbff515
numatune: setting --mode does not work well

When trying to set numatune mode directly using virsh numatune command,
correct error is raised, however numatune structure was not deallocated,
thus resulting in creating an empty numatune element in the guest XML,
if none was present before. Running the same command aftewards results
in a successful change with broken XML structure. Patch fixes the
deallocation problem as well as checking for invalid attribute
combination VIR_DOMAIN_NUMATUNE_PLACEMENT_AUTO + a nonempty nodeset.

Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1129998
src/conf/numatune_conf.c
tests/qemuxml2argvdata/qemuxml2argv-numad-auto-vcpu-static-numatune-no-nodeset.xml [new file with mode: 0644]
tests/qemuxml2argvtest.c