]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
devlink: Fix parent ref leak in devl_rate_node_create()
authorCosmin Ratiu <cratiu@nvidia.com>
Tue, 16 Jun 2026 11:06:32 +0000 (14:06 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 19 Jun 2026 01:02:29 +0000 (18:02 -0700)
commitba45106342bbdd905651cb9fcefb8c11871d4c25
treeefd167d7676ceecc78e589864b4cba8889476e58
parent8cdcf3d2caacdee7ddd363705fb4d93b0c1a0915
devlink: Fix parent ref leak in devl_rate_node_create()

In the original commit the function bails out on kstrdup failure,
forgetting to decrement the refcnt of the parent.

Fix that by moving the parent refcnt setting after kstrdup.

Fixes: caba177d7f4d ("devlink: Enable creation of the devlink-rate nodes from the driver")
Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260616110633.1449432-2-cratiu@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/devlink/rate.c