]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nvme/pci: move cqe check after device shutdown
authorKeith Busch <kbusch@kernel.org>
Wed, 12 Feb 2020 16:41:05 +0000 (01:41 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Mar 2020 15:45:13 +0000 (16:45 +0100)
commitba7d6a9f7f42ccbcc37829d9b997d8da4de9ffc1
treefd7a7e80350cbc1fd95e4d5a858917d9955e20d6
parent4b68fd306ec3825f963eb712945337049df97d41
nvme/pci: move cqe check after device shutdown

[ Upstream commit fa46c6fb5d61b1f17b06d7c6ef75478b576304c7 ]

Many users have reported nvme triggered irq_startup() warnings during
shutdown. The driver uses the nvme queue's irq to synchronize scanning
for completions, and enabling an interrupt affined to only offline CPUs
triggers the alarming warning.

Move the final CQE check to after disabling the device and all
registered interrupts have been torn down so that we do not have any
IRQ to synchronize.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=206509
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/nvme/host/pci.c