]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
pinctrl: qcom: Modify MSM_PULL_MASK to accurately represent PULL bits
authorSneh Mankad <sneh.mankad@oss.qualcomm.com>
Fri, 29 May 2026 12:55:44 +0000 (18:25 +0530)
committerLinus Walleij <linusw@kernel.org>
Mon, 8 Jun 2026 19:30:46 +0000 (21:30 +0200)
commitba80761235bb526e7700468baaa9bddffebc3320
tree16c496d31236278848e1359348097bd8cbc39b23
parentb719ede389d8a6b3fb24d3a6641fec2e46d8ff36
pinctrl: qcom: Modify MSM_PULL_MASK to accurately represent PULL bits

MSM_PULL_MASK currently spans bits [2:0], but the GPIO_PULL field in the
GPIO_CFG register only occupies bits [1:0]. Bit 2 belongs to
FUNC_SEL.

MSM_PULL_MASK is used to isolate the GPIO_PULL bits before writing the
pull configuration (PULL_DOWN: 0x1, PULL_UP: 0x3) to the GPIO_CFG
register. Narrow it to bits [1:0] to prevent unintended modification of
the FUNC_SEL field.

This causes no functional change since the driver currently does not
modify the FUNC_SEL bit, but align the mask with hardware configuration
nonetheless.

Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>
drivers/pinctrl/qcom/tlmm-test.c