]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm: Don't treat 0 as -1 in drm_fixp2int_ceil
authorHarry Wentland <harry.wentland@amd.com>
Wed, 8 Nov 2023 16:36:20 +0000 (11:36 -0500)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:42 +0000 (18:19 -0400)
commitbac3d37d2f7cab3d9c42a7c9775c84aee4fa89d9
tree86e658ca888cdfc8a2cccecfb29a9a00e0c59df6
parent9ac30fb8fae69dcf19509ef26ca8f350fe281ecc
drm: Don't treat 0 as -1 in drm_fixp2int_ceil

[ Upstream commit cf8837d7204481026335461629b84ac7f4538fa5 ]

Unit testing this in VKMS shows that passing 0 into
this function returns -1, which is highly counter-
intuitive. Fix it by checking whether the input is
>= 0 instead of > 0.

Fixes: 64566b5e767f ("drm: Add drm_fixp_from_fraction and drm_fixp2int_ceil")
Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Simon Ser <contact@emersion.fr>
Reviewed-by: Melissa Wen <mwen@igalia.com>
Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231108163647.106853-2-harry.wentland@amd.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/drm/drm_fixed.h