]> git.ipfire.org Git - thirdparty/libvirt.git/commit
projects / thirdparty / libvirt.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1b21d30) | patch
vmx: Fix a VMX parsing problem
authorGeoff Hickey <ghickey@datagravity.com>
Wed, 7 Jan 2015 23:45:42 +0000 (18:45 -0500)
committerEric Blake <eblake@redhat.com>
Thu, 8 Jan 2015 00:17:00 +0000 (17:17 -0700)
commitbb072e8a38d1d6d2f7819bbcb8ff106520081667
treeddd66e88bd1242165b710804e14027c1b35eeb2ctree | snapshot
parent1b21d300691a78f73d94446616a6d1f9fd88991ecommit | diff
vmx: Fix a VMX parsing problem

VMware ESX does not always set the "serialX.fileType" tag in VMX files. The
default value for this tag is "device", and when adding a new serial port
of this type VMware will omit the fileType tag. This caused libvirt to
fail to parse the VMX file. Fixed by making this tag optional and using
"device" as a default value. Also updated vmx2xmltest to test for this
case.

Signed-off-by: Eric Blake <eblake@redhat.com>
src/vmx/vmx.c diff | blob | blame | history
tests/vmx2xmldata/vmx2xml-serial-device.vmx diff | blob | blame | history
tests/vmx2xmldata/vmx2xml-serial-device.xml diff | blob | blame | history
Mirror of https://github.com/libvirt/libvirt.git