]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix issue with EVENT TRIGGERS and ALTER PUBLICATION
authorDavid Rowley <drowley@postgresql.org>
Tue, 6 Jan 2026 04:30:08 +0000 (17:30 +1300)
committerDavid Rowley <drowley@postgresql.org>
Tue, 6 Jan 2026 04:30:08 +0000 (17:30 +1300)
commitbb08ac7ac38763076e5507559d9a8b0559572258
tree4f31921bd29ad9f75b3f42cfb09c2264a6b5ced2
parent358784645eb864a805a859405d50386c9a3805b8
Fix issue with EVENT TRIGGERS and ALTER PUBLICATION

When processing the "publish" options of an ALTER PUBLICATION command,
we call SplitIdentifierString() to split the options into a List of
strings.  Since SplitIdentifierString() modifies the delimiter
character and puts NULs in their place, this would overwrite the memory
of the AlterPublicationStmt.  Later in AlterPublicationOptions(), the
modified AlterPublicationStmt is copied for event triggers, which would
result in the event trigger only seeing the first "publish" option
rather than all options that were specified in the command.

To fix this, make a copy of the string before passing to
SplitIdentifierString().

Here we also adjust a similar case in the pgoutput plugin.  There's no
known issues caused by SplitIdentifierString() here, so this is being
done out of paranoia.

Thanks to Henson Choi for putting together an example case showing the
ALTER PUBLICATION issue.

Author: sunil s <sunilfeb26@gmail.com>
Reviewed-by: Henson Choi <assam258@gmail.com>
Reviewed-by: zengman <zengman@halodbtech.com>
Backpatch-through: 14
src/backend/commands/publicationcmds.c
src/backend/replication/pgoutput/pgoutput.c