]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Make rewriter prevent auto-updates on views with conditional INSTEAD rules.
authorDean Rasheed <dean.a.rasheed@gmail.com>
Tue, 14 Jan 2020 09:48:44 +0000 (09:48 +0000)
committerDean Rasheed <dean.a.rasheed@gmail.com>
Tue, 14 Jan 2020 09:48:44 +0000 (09:48 +0000)
commitbb09a9414f1e149aac6064d217b5d5cab8f13723
tree552afd2f90ac5a8a400b0be37ce2ae0d5c446dfd
parent784c58da1957cecdea037428ce08953b852be85b
Make rewriter prevent auto-updates on views with conditional INSTEAD rules.

A view with conditional INSTEAD rules and no unconditional INSTEAD
rules or INSTEAD OF triggers is not auto-updatable. Previously we
relied on a check in the executor to catch this, but that's
problematic since the planner may fail to properly handle such a query
and thus return a particularly unhelpful error to the user, before
reaching the executor check.

Instead, trap this in the rewriter and report the correct error there.
Doing so also allows us to include more useful error detail than the
executor check can provide. This doesn't change the existing behaviour
of updatable views; it merely ensures that useful error messages are
reported when a view isn't updatable.

Per report from Pengzhou Tang, though not adopting that suggested fix.
Back-patch to all supported branches.

Discussion: https://postgr.es/m/CAG4reAQn+4xB6xHJqWdtE0ve_WqJkdyCV4P=trYr4Kn8_3_PEA@mail.gmail.com
src/backend/executor/execMain.c
src/backend/rewrite/rewriteHandler.c
src/test/regress/expected/updatable_views.out
src/test/regress/sql/updatable_views.sql