]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
uprobes: change uprobe_register() to use uprobe_unregister() instead of __uprobe_unre...
authorOleg Nesterov <oleg@redhat.com>
Thu, 1 Aug 2024 13:27:39 +0000 (15:27 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Fri, 2 Aug 2024 09:30:32 +0000 (11:30 +0200)
commitbb18c5de1c288050ef8bd4af4ca16896ad4cd3fc
tree9ca4aafead6f962321612826b3c34f9e0039ad46
parent3c83a9ad0295eb63bdeb81d821b8c3b9417fbcac
uprobes: change uprobe_register() to use uprobe_unregister() instead of __uprobe_unregister()

If register_for_each_vma() fails uprobe_register() can safely drop
uprobe->register_rwsem and use uprobe_unregister(). There is no worry
about the races with another register/unregister, consumer_add() was
already called so this case doesn't differ from _unregister() right
after the successful _register().

Yes this means the extra up_write() + down_write(), but this is the
slow and unlikely case anyway.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Link: https://lore.kernel.org/r/20240801132739.GA8809@redhat.com
kernel/events/uprobes.c