]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
batman-adv: fix OOB read/write in network-coding decode
authorStanislav Fort <stanislav.fort@aisle.com>
Sun, 31 Aug 2025 14:56:23 +0000 (16:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 9 Sep 2025 16:56:27 +0000 (18:56 +0200)
commitbb37252c9af1cb250f34735ee98f80b46be3cef1
treeea28a7464a399d83e485e2b665a1e97ca8005f31
parentd96cc9a1b57725930c60b607423759d563b4d900
batman-adv: fix OOB read/write in network-coding decode

commit d77b6ff0ce35a6d0b0b7b9581bc3f76d041d4087 upstream.

batadv_nc_skb_decode_packet() trusts coded_len and checks only against
skb->len. XOR starts at sizeof(struct batadv_unicast_packet), reducing
payload headroom, and the source skb length is not verified, allowing an
out-of-bounds read and a small out-of-bounds write.

Validate that coded_len fits within the payload area of both destination
and source sk_buffs before XORing.

Fixes: 2df5278b0267 ("batman-adv: network coding - receive coded packets and decode them")
Cc: stable@vger.kernel.org
Reported-by: Stanislav Fort <disclosure@aisle.com>
Signed-off-by: Stanislav Fort <stanislav.fort@aisle.com>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/batman-adv/network-coding.c