]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/vc4: txp: Don't set TXP_VSTART_AT_EOF
authorMaxime Ripard <maxime@cerno.tech>
Mon, 28 Mar 2022 15:36:55 +0000 (17:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 14:59:19 +0000 (16:59 +0200)
commitbb59345bb77591d66089cc2d8050ba82ecb41b32
tree3864e1c8c250568b210036946bb9ebe3586150e8
parent34a4ddeaced0b059d82f78541e2d9b1a79a25a9f
drm/vc4: txp: Don't set TXP_VSTART_AT_EOF

[ Upstream commit 234998df929f14d00cbf2f1e81a7facb69fd9266 ]

The TXP_VSTART_AT_EOF will generate a second VSTART signal to the HVS.
However, the HVS waits for VSTART to enable the FIFO and will thus start
filling the FIFO before the start of the frame.

This leads to corruption at the beginning of the first frame, and
content from the previous frame at the beginning of the next frames.

Since one VSTART is enough, let's get rid of it.

Fixes: 008095e065a8 ("drm/vc4: Add support for the transposer block")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20220328153659.2382206-3-maxime@cerno.tech
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/vc4/vc4_txp.c