]> git.ipfire.org Git - thirdparty/knot-resolver.git/commit
lib/selection: minor refactorings and comments
authorVladimír Čunát <vladimir.cunat@nic.cz>
Tue, 22 Dec 2020 10:29:39 +0000 (11:29 +0100)
committerVladimír Čunát <vladimir.cunat@nic.cz>
Thu, 31 Dec 2020 14:42:06 +0000 (15:42 +0100)
commitbb655fdee67e4381ead06793137efdea2e206994
tree1af3b90b45ac0b8d242886e973d134417ee48bcf
parentb3a8bbb42e0e1bab9ea5e71f96ddd86574774227
lib/selection: minor refactorings and comments

Small things I've noticed while reading it all.
- line breaks: I believe <90 is OK, as usually the attempts to reduce
  lengths impair readability
- avoid unnecessary casts; usually the type was visible
  on the same line anyway
- avoid `|` on booleans
- one block gets de-indented (often badly shown in diffs)
- no need for UNRECOVERABLE_ERRORS in a header (and a weird one, too)
- recoverability from failed assertions (in case they're turned off)
lib/layer/iterate.c
lib/selection.c
lib/selection.h
lib/selection_forward.c
lib/selection_iter.c
lib/selection_iter.h