]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
blk-throttle: make sure expire time isn't too big
authorShaohua Li <shli@fb.com>
Mon, 27 Mar 2017 17:51:36 +0000 (10:51 -0700)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:33:44 +0000 (21:33 -0400)
commitbb6a360340df970553b832faa22bff78aafc6c17
treea35318e59f88067e3df6a72dbb32469356a3e6ef
parent62be09cdc8ef701cfad714c90d8d0b2ef24bc5eb
blk-throttle: make sure expire time isn't too big

[ Upstream commit 06cceedcca67a93ac7f7aa93bbd9980c7496d14e ]

cgroup could be throttled to a limit but when all cgroups cross high
limit, queue enters a higher state and so the group should be throttled
to a higher limit. It's possible the cgroup is sleeping because of
throttle and other cgroups don't dispatch IO any more. In this case,
nobody can trigger current downgrade/upgrade logic. To fix this issue,
we could either set up a timer to wakeup the cgroup if other cgroups are
idle or make sure this cgroup doesn't sleep too long. Setting up a timer
means we must change the timer very frequently. This patch chooses the
latter. Making cgroup sleep time not too big wouldn't change cgroup
bps/iops, but could make it wakeup more frequently, which isn't a big
issue because throtl_slice * 8 is already quite big.

Signed-off-by: Shaohua Li <shli@fb.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
block/blk-throttle.c