]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
Revert "drm/etnaviv: Use dma_buf from GEM object instance"
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 15 Jul 2025 15:58:13 +0000 (17:58 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Thu, 17 Jul 2025 10:26:19 +0000 (12:26 +0200)
commitbb7f4972a6ff9a537b87e1b0ecf0e561f2761dd3
tree0f70c5003e23098cdf2a475c6601998392c18aa7
parent1e9d2aed7c2248bc5ba7d0dfea4fcc0b2f80b4f7
Revert "drm/etnaviv: Use dma_buf from GEM object instance"

This reverts commit e91eb3ae415472b28211d7fed07fa283845b311e.

The dma_buf field in struct drm_gem_object is not stable over the
object instance's lifetime. The field becomes NULL when user space
releases the final GEM handle on the buffer object. This resulted
in a NULL-pointer deref.

Workarounds in commit 5307dce878d4 ("drm/gem: Acquire references on
GEM handles for framebuffers") and commit f6bfc9afc751 ("drm/framebuffer:
Acquire internal references on GEM handles") only solved the problem
partially. They especially don't work for buffer objects without a DRM
framebuffer associated.

Hence, this revert to going back to using .import_attach->dmabuf.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Simona Vetter <simona.vetter@ffwll.ch>
Acked-by: Christian König <christian.koenig@amd.com>
Acked-by: Zack Rusin <zack.rusin@broadcom.com>
Link: https://lore.kernel.org/r/20250715155934.150656-4-tzimmermann@suse.de
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c