]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cifs: Fix memory and information leak in smb3_reconfigure()
authorZilin Guan <zilin@seu.edu.cn>
Wed, 24 Dec 2025 15:21:42 +0000 (15:21 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 Jan 2026 11:57:04 +0000 (12:57 +0100)
commitbb82aaee16907dc4d0b9b0ca7953ceb3edc328c6
tree28bf1be67c3f362beba85171f2dd1bae1cc6a6a8
parentf8b19571b1db094525a7d4db9e16df2a1b4a6cfd
cifs: Fix memory and information leak in smb3_reconfigure()

[ Upstream commit cb6d5aa9c0f10074f1ad056c3e2278ad2cc7ec8d ]

In smb3_reconfigure(), if smb3_sync_session_ctx_passwords() fails, the
function returns immediately without freeing and erasing the newly
allocated new_password and new_password2. This causes both a memory leak
and a potential information leak.

Fix this by calling kfree_sensitive() on both password buffers before
returning in this error case.

Fixes: 0f0e357902957 ("cifs: during remount, make sure passwords are in sync")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/smb/client/fs_context.c