]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
printk: Fix signed integer overflow when defining LOG_BUF_LEN_MAX
authorKuan-Wei Chiu <visitorckw@gmail.com>
Sat, 28 Sep 2024 11:36:08 +0000 (19:36 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:50:17 +0000 (12:50 +0100)
commitbb8ff054e19fe27f4e5eaac1b05e462894cfe9b1
tree177253628965015f5596f85deee6fb49a21b52ef
parent99795e62e7a57d8dd82b82f226359c8a38fae030
printk: Fix signed integer overflow when defining LOG_BUF_LEN_MAX

[ Upstream commit 3d6f83df8ff2d5de84b50377e4f0d45e25311c7a ]

Shifting 1 << 31 on a 32-bit int causes signed integer overflow, which
leads to undefined behavior. To prevent this, cast 1 to u32 before
performing the shift, ensuring well-defined behavior.

This change explicitly avoids any potential overflow by ensuring that
the shift occurs on an unsigned 32-bit integer.

Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Acked-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20240928113608.1438087-1-visitorckw@gmail.com
Signed-off-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/printk/printk.c