]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
random: mix build-time latent entropy into pool at init
authorJason A. Donenfeld <Jason@zx2c4.com>
Thu, 31 Mar 2022 15:01:01 +0000 (11:01 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 25 Jun 2022 09:46:37 +0000 (11:46 +0200)
commitbba3aac2241f5f3792c405e5a01e7a9fdbc5e249
treeeffdc3e1c7be26e469d5caaf7b8e8c604a6d2eef
parentcd852448d59e95c913abeb5b95e060a1003e87c9
random: mix build-time latent entropy into pool at init

commit 1754abb3e7583c570666fa1e1ee5b317e88c89a0 upstream.

Prior, the "input_pool_data" array needed no real initialization, and so
it was easy to mark it with __latent_entropy to populate it during
compile-time. In switching to using a hash function, this required us to
specifically initialize it to some specific state, which means we
dropped the __latent_entropy attribute. An unfortunate side effect was
this meant the pool was no longer seeded using compile-time random data.
In order to bring this back, we declare an array in rand_initialize()
with __latent_entropy and call mix_pool_bytes() on that at init, which
accomplishes the same thing as before. We make this __initconst, so that
it doesn't take up space at runtime after init.

Fixes: 6e8ec2552c7d ("random: use computational hash for entropy extraction")
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/random.c