]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
PCI: Fix reference leak in pci_register_host_bridge()
authorMa Ke <make24@iscas.ac.cn>
Tue, 25 Feb 2025 02:14:40 +0000 (10:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 20 Apr 2025 08:18:25 +0000 (10:18 +0200)
commitbbba4c50a2d2a1d3f3bf31cc4b8280cb492bf2c7
treed4ae3aee7904b518338a47e24177ee0984c67a66
parent1bf3ccb3a731e1a7db1cb3d2f85d0decc0d2f26b
PCI: Fix reference leak in pci_register_host_bridge()

commit 804443c1f27883926de94c849d91f5b7d7d696e9 upstream.

If device_register() fails, call put_device() to give up the reference to
avoid a memory leak, per the comment at device_register().

Found by code review.

Link: https://lore.kernel.org/r/20250225021440.3130264-1-make24@iscas.ac.cn
Fixes: 37d6a0a6f470 ("PCI: Add pci_register_host_bridge() interface")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
[bhelgaas: squash Dan Carpenter's double free fix from
https://lore.kernel.org/r/db806a6c-a91b-4e5a-a84b-6b7e01bdac85@stanley.mountain]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pci/probe.c