]> git.ipfire.org Git - thirdparty/linux.git/commit
readahead: fix return value of page_cache_next_miss() when no hole is found
authorChi Zhiling <chizhiling@kylinos.cn>
Thu, 5 Jun 2025 05:49:35 +0000 (13:49 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 10 Jul 2025 05:41:59 +0000 (22:41 -0700)
commitbbcaee20e03ecaeeecba32a703816a0d4502b6c4
tree2502cf4dc620c623eaa7962fa7d2e247304129e8
parent08e21e241210a3a124cfafd33db3dbda49b6f43d
readahead: fix return value of page_cache_next_miss() when no hole is found

max_scan in page_cache_next_miss always decreases to zero when no hole is
found, causing the return value to be index + 0.

Fix this by preserving the max_scan value throughout the loop.

Jan said "From what I know and have seen in the past, wrong responses
from page_cache_next_miss() can lead to readahead window reduction and
thus reduced read speeds."

Link: https://lkml.kernel.org/r/20250605054935.2323451-1-chizhiling@163.com
Fixes: 901a269ff3d5 ("filemap: fix page_cache_next_miss() when no hole found")
Signed-off-by: Chi Zhiling <chizhiling@kylinos.cn>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Josef Bacik <josef@toxicpanda.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/filemap.c