]> git.ipfire.org Git - thirdparty/libvirt.git/commit
conf: Don't mangle vcpu placement randomly
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 22 Jan 2015 12:57:22 +0000 (13:57 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 30 Jan 2015 12:51:22 +0000 (13:51 +0100)
commitbbd3eb50987676f486effe55feec1fe0d01cafd0
tree583a66a7f0caa7620f1ed0d53a480a4646b65759
parent79a876947995bc2f98c417b00d92a1e0bcc090fa
conf: Don't mangle vcpu placement randomly

https://bugzilla.redhat.com/show_bug.cgi?id=1170492

In one of our previous commits (dc8b7ce7) we've done a functional
change even though it was intended as pure refactor. The problem is,
that the following XML:

 <vcpu placement='static' current='2'>6</vcpu>
 <cputune>
   <emulatorpin cpuset='1-3'/>
 </cputune>
 <numatune>
   <memory mode='strict' placement='auto'/>
 </numatune>

gets translated into this one:

 <vcpu placement='auto' current='2'>6</vcpu>
 <cputune>
   <emulatorpin cpuset='1-3'/>
 </cputune>
 <numatune>
   <memory mode='strict' placement='auto'/>
 </numatune>

We should not change the vcpu placement mode. Moreover, we're doing
something similar in case of emulatorpin and iothreadpin. If they were
set, but vcpu placement was auto, we've mistakenly removed them from
the domain XML even though we are able to set them independently on
vcpus.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
docs/formatdomain.html.in
src/conf/domain_conf.c
tests/qemuxml2argvdata/qemuxml2argv-cputune-numatune.xml [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-vcpu-placement-static.xml [new file with mode: 0644]
tests/qemuxml2xmltest.c