]> git.ipfire.org Git - thirdparty/gcc.git/commit
libstdc++: Use RDRAND as fallback if RDSEED keeps failing (PR 94087)
authorJonathan Wakely <jwakely@redhat.com>
Tue, 19 May 2020 15:49:21 +0000 (16:49 +0100)
committerJonathan Wakely <jwakely@redhat.com>
Thu, 9 Jul 2020 08:53:14 +0000 (09:53 +0100)
commitbbf9d358ae2104a09fc1b61e2b818928b6591831
tree1ac339974cc9fab23e41aa930737667e32304d9f
parente506371e7003381c73d180d3ce4f3e51df8ad856
libstdc++: Use RDRAND as fallback if RDSEED keeps failing (PR 94087)

It's not difficult for multiple threads to drain the entropy available
to the RDSEED instruction, at which point we throw an exception. This
change will try to use RDRAND after RDSEED fails repeatedly, and only
throw if RDRAND also fails repeatedly. This doesn't guarantee a random
value can always be read, but reduces the likelihood of failure when
using the RDSEED instruction.

PR libstdc++/94087
* src/c++11/random.cc (__x86_rdseed): Allow fallback function to be
passed in.
(__x86_rdseed_rdrand): New function that uses rdseed with rdrand
fallback.
(random_device::_M_init): Use __x86_rdseed_rdrand when both
instructions are available.
* testsuite/26_numerics/random/random_device/94087.cc: New test.

(cherry picked from commit a2d196e75cef95c2b70734ad02e94f9da0e769fe)
libstdc++-v3/src/c++11/random.cc
libstdc++-v3/testsuite/26_numerics/random/random_device/94087.cc [new file with mode: 0644]