]> git.ipfire.org Git - thirdparty/samba.git/commit
selftest: fix acl_xattr test: sn-devel unreliable gid
authorRalph Boehme <slow@samba.org>
Sun, 8 Oct 2017 06:51:05 +0000 (08:51 +0200)
committerKarolin Seeger <kseeger@samba.org>
Wed, 25 Oct 2017 06:43:00 +0000 (08:43 +0200)
commitbc555905652e1d8079576def238ce6ffabb95951
tree5d8deb183e1b6e1fced7e8831d1833507ed96af8
parent7b72c6f9064b6f610f5c692e899eb55b446f1428
selftest: fix acl_xattr test: sn-devel unreliable gid

The "nt_affects_chgrp" kept failing in a full autobuild on sn-devel
because the actual gid of the created file as returned by smbclient -c
getfacl was reliably the unix gid of my account. It should have been the
mapped domusers group for the primary users "Domain Users"
group. Running the test individually or even the full set of
"samba3.blackbox" tests didn't trigger the error.

Looks like an issue with vfs_fake_acls and vfs_xattr_tdb, but I wasn't
able to track it down. As the test only really want to ensure that
smbcacls -G set the gid to the requested value, just remove the check
for the actual initial gid.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=7933

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit ea0ea829f5af63ab9638e758631c3002cbb6b4ce)
source3/script/tests/test_acl_xattr.sh