]> git.ipfire.org Git - thirdparty/libvirt.git/commit
conf: prevent crash with no uuid in cephx auth secret
authorJán Tomko <jtomko@redhat.com>
Mon, 3 Dec 2012 12:35:05 +0000 (13:35 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 3 Dec 2012 14:13:32 +0000 (15:13 +0100)
commitbc680e1381be7eeb5ae7d898ebab598df819b672
tree8006d56197f4e24275dbe3f354ae6c002534ad77
parent05858b27d408e0b1d0c10f511e69f29e45ac6f7b
conf: prevent crash with no uuid in cephx auth secret

Fix the null pointer access when UUID is not specified.
Introduce a bool 'uuidUsable' to virStoragePoolAuthCephx that indicates
if uuid was specified or not and use it instead of the pointless
comparison of the static UUID array to NULL.
Add an error message if both uuid and usage are specified.

Fixes:
Error: FORWARD_NULL (CWE-476):
libvirt-0.10.2/src/conf/storage_conf.c:461: var_deref_model: Passing
    null pointer "uuid" to function "virUUIDParse(char const *, unsigned
    char *)", which dereferences it. (The dereference is assumed on the
    basis of the 'nonnull' parameter attribute.)
Error: NO_EFFECT (CWE-398):
    libvirt-0.10.2/src/conf/storage_conf.c:979: array_null: Comparing an
    array to null is not useful: "src->auth.cephx.secret.uuid != NULL".
src/conf/storage_conf.c
src/conf/storage_conf.h
src/storage/storage_backend_rbd.c