]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ipv4: fix nexthop attlen check in fib_nh_match
authorJiri Pirko <jiri@resnulli.us>
Mon, 13 Oct 2014 14:34:10 +0000 (16:34 +0200)
committerJiri Slaby <jslaby@suse.cz>
Wed, 5 Nov 2014 09:03:20 +0000 (10:03 +0100)
commitbc9b1233fe48f27c2325de5ccc584c4b2a0ce12c
tree87e018878b1d8040adb536771300b9b32823939d
parent7fccdb578ab6a71fc23690f772d37e7f0050a6bf
ipv4: fix nexthop attlen check in fib_nh_match

[ Upstream commit f76936d07c4eeb36d8dbb64ebd30ab46ff85d9f7 ]

fib_nh_match does not match nexthops correctly. Example:

ip route add 172.16.10/24 nexthop via 192.168.122.12 dev eth0 \
                          nexthop via 192.168.122.13 dev eth0
ip route del 172.16.10/24 nexthop via 192.168.122.14 dev eth0 \
                          nexthop via 192.168.122.15 dev eth0

Del command is successful and route is removed. After this patch
applied, the route is correctly matched and result is:
RTNETLINK answers: No such process

Please consider this for stable trees as well.

Fixes: 4e902c57417c4 ("[IPv4]: FIB configuration using struct fib_config")
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_semantics.c