]> git.ipfire.org Git - thirdparty/pdns.git/commit
dnsreplay had odd race conditions in sending/reseinding packets
authorbert hubert <bert.hubert@netherlabs.nl>
Wed, 23 Apr 2014 19:42:31 +0000 (21:42 +0200)
committerbert hubert <bert.hubert@netherlabs.nl>
Wed, 23 Apr 2014 19:42:31 +0000 (21:42 +0200)
commitbc9e03a07981cf86935376dd61e9fbea247fc548
treed8a9606e3455f06278c63fb2b2c88f52df1e8356
parent2dfd6b650cf5af6bd419ab208f1f60ea626ecbe1
dnsreplay had odd race conditions in sending/reseinding packets
We had logic to pre-read the first packet for better error reporting, and then not read it at the top of the while loop,
but process the pre-read packet. However, this logic kept engaging, causing us to retransmit the previous packet a lot, depending
on the size of our retransmit window, which in turn depended on the receiver characteristic. Horrible.
dnsreplay may previously have overstated the number of duplicate packets because of this.
pdns/dnsreplay.cc