]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: phy: adin1100: Fix software power-down ready condition
authorAlexander Dahl <ada@thorsis.com>
Wed, 19 Nov 2025 12:47:36 +0000 (13:47 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 21 Nov 2025 02:03:59 +0000 (18:03 -0800)
commitbccaf1fe08f2c9f96f6bc38391d41e67f6bf38e3
tree1cf52b2f85fbeaafe824b1e069fa6a6f953ea3f8
parent22eaa206fcacc54e8bc0487c7667883df9200e57
net: phy: adin1100: Fix software power-down ready condition

Value CRSM_SFT_PD written to Software Power-Down Control Register
(CRSM_SFT_PD_CNTRL) is 0x01 and therefor different to value
CRSM_SFT_PD_RDY (0x02) read from System Status Register (CRSM_STAT) for
confirmation powerdown has been reached.

The condition could have only worked when disabling powerdown
(both 0x00), but never when enabling it (0x01 != 0x02).

Result is a timeout, like so:

    $ ifdown eth0
    macb f802c000.ethernet eth0: Link is Down
    ADIN1100 f802c000.ethernet-ffffffff:01: adin_set_powerdown_mode failed: -110
    ADIN1100 f802c000.ethernet-ffffffff:01: adin_set_powerdown_mode failed: -110

Fixes: 7eaf9132996a ("net: phy: adin1100: Add initial support for ADIN1100 industrial PHY")
Signed-off-by: Alexander Dahl <ada@thorsis.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Acked-by: Nuno Sá <nuno.sa@analog.com>
Link: https://patch.msgid.link/20251119124737.280939-2-ada@thorsis.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/adin1100.c