]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/bridge: cdns-dsi: Drop checks that shouldn't be in .mode_valid()
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Wed, 23 Jul 2025 10:05:13 +0000 (13:05 +0300)
committerTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Wed, 13 Aug 2025 07:20:37 +0000 (10:20 +0300)
commitbcd6808aff4029a7df690cf4c9911e5cc826098d
treea72f3bda91e5043e62028f57878fa19964784042
parent644696a4c48b27d99ff68fa6fee4efcf3910eef5
drm/bridge: cdns-dsi: Drop checks that shouldn't be in .mode_valid()

The docs say about mode_valid():

"it is not allowed to look at anything else but the passed-in mode, and
validate it against configuration-invariant hardware constraints"

We're doing a lot more than just looking at the mode. The main issue
here is that we're doing checks based on the pixel clock, before we know
what the pixel clock from the crtc actually is.

So, drop the cdns_dsi_check_conf() call from .mode_valid().

Reviewed-by: Aradhya Bhatia <aradhya.bhatia@linux.dev>
Tested-by: Parth Pancholi <parth.pancholi@toradex.com>
Tested-by: Jayesh Choudhary <j-choudhary@ti.com>
Reviewed-by: Devarsh Thakkar <devarsht@ti.com>
Link: https://lore.kernel.org/r/20250723-cdns-dsi-impro-v5-7-e61cc06074c2@ideasonboard.com
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c