]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
serial: max310x: Do not hard-code the IRQ type
authorJan Kundrát <jan.kundrat@cesnet.cz>
Fri, 8 Dec 2017 21:41:35 +0000 (22:41 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Dec 2017 08:59:01 +0000 (09:59 +0100)
commitbceb483972cf6f4904aa563cd6f292a1f4c7a565
tree343cd10f911c139e12475d2b852dda692309ea9c
parent793ae04c46cf054a6342671de3fabb1b5131a880
serial: max310x: Do not hard-code the IRQ type

As suggested by Russell King, a driver should not really care about bits
such as the interrupt polarity or whether it is edge- or level-
triggered. The reasons for that include:

- an upstream IRQ controller which cannot support edge- or
level-triggered interrupts,
- board design with a built-in inverter

The interrupt type is being already specified by the Device Tree,
anyway. Other drivers (gpio/gpio-tc3589x.c for example) already work in
this way, delegating the proper IRQ line setup to the DT and not
specifying anything by hand.

Also, there's no reason to have the IRQ flags split between two places.
The SPI probing is the only entry point anyway.

Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/max310x.c