]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
PCI: Fix reference leak in pci_register_host_bridge()
authorMa Ke <make24@iscas.ac.cn>
Tue, 25 Feb 2025 02:14:40 +0000 (10:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 May 2025 05:50:41 +0000 (07:50 +0200)
commitbd2a352a0d72575f1842d28c14c10089f0cfe1ae
treeb973fe28c49ff996fb7fd7033a0ef857a43dfc6d
parent81435b85b2ebc7f5df404290e709e69f35749493
PCI: Fix reference leak in pci_register_host_bridge()

[ Upstream commit 804443c1f27883926de94c849d91f5b7d7d696e9 ]

If device_register() fails, call put_device() to give up the reference to
avoid a memory leak, per the comment at device_register().

Found by code review.

Link: https://lore.kernel.org/r/20250225021440.3130264-1-make24@iscas.ac.cn
Fixes: 37d6a0a6f470 ("PCI: Add pci_register_host_bridge() interface")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
[bhelgaas: squash Dan Carpenter's double free fix from
https://lore.kernel.org/r/db806a6c-a91b-4e5a-a84b-6b7e01bdac85@stanley.mountain]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: stable@vger.kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/probe.c