]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
workqueue: RCU protect wq->dfl_pwq and implement accessors for it
authorTejun Heo <tj@kernel.org>
Mon, 29 Jan 2024 18:11:24 +0000 (08:11 -1000)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:16 +0000 (18:19 -0400)
commitbd31fb926dfa02d2ccfb4b79389168b1d16f36b1
treede7cdfc1b012d6aa6747464cc28a6d66bb984607
parent5f99fee6f2dea1228980c3e785ab1a2c69b4da3c
workqueue: RCU protect wq->dfl_pwq and implement accessors for it

[ Upstream commit 9f66cff212bb3c1cd25996aaa0dfd0c9e9d8baab ]

wq->cpu_pwq is RCU protected but wq->dfl_pwq isn't. This is okay because
currently wq->dfl_pwq is used only accessed to install it into wq->cpu_pwq
which doesn't require RCU access. However, we want to be able to access
wq->dfl_pwq under RCU in the future to access its __pod_cpumask and the code
can be made easier to read by making the two pwq fields behave in the same
way.

- Make wq->dfl_pwq RCU protected.

- Add unbound_pwq_slot() and unbound_pwq() which can access both ->dfl_pwq
  and ->cpu_pwq. The former returns the double pointer that can be used
  access and update the pwqs. The latter performs locking check and
  dereferences the double pointer.

- pwq accesses and updates are converted to use unbound_pwq[_slot]().

Signed-off-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>
Stable-dep-of: 5797b1c18919 ("workqueue: Implement system-wide nr_active enforcement for unbound workqueues")
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/workqueue.c