]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: fcoe: Memory leak fix in fcoe_sysfs_fcf_del()
authorJaved Hasan <jhasan@marvell.com>
Wed, 29 Jul 2020 08:18:24 +0000 (01:18 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Sep 2020 09:19:25 +0000 (11:19 +0200)
commitbd64f40ad711f8960a62c229d2a26375accd92f6
treee0ab2d881e1bbb18ba83a8ba08333362eb993509
parenta54a180e4c23a4d4dbaa4532d38441720f2f1941
scsi: fcoe: Memory leak fix in fcoe_sysfs_fcf_del()

[ Upstream commit e95b4789ff4380733006836d28e554dc296b2298 ]

In fcoe_sysfs_fcf_del(), we first deleted the fcf from the list and then
freed it if ctlr_dev was not NULL. This was causing a memory leak.

Free the fcf even if ctlr_dev is NULL.

Link: https://lore.kernel.org/r/20200729081824.30996-3-jhasan@marvell.com
Reviewed-by: Girish Basrur <gbasrur@marvell.com>
Reviewed-by: Santosh Vernekar <svernekar@marvell.com>
Reviewed-by: Saurav Kashyap <skashyap@marvell.com>
Reviewed-by: Shyam Sundar <ssundar@marvell.com>
Signed-off-by: Javed Hasan <jhasan@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/fcoe/fcoe_ctlr.c