]> git.ipfire.org Git - thirdparty/openwrt.git/commit
image: fix race between mkits.sh and mkimage in .itb squashfs generation
authorChristian Marangi <ansuelsmth@gmail.com>
Wed, 22 Oct 2025 00:17:25 +0000 (02:17 +0200)
committerChristian Marangi <ansuelsmth@gmail.com>
Thu, 23 Oct 2025 16:16:33 +0000 (18:16 +0200)
commitbdb89ee6dff4742f2d7bcf101077ee6f9f8031f7
tree5edf31e421f77d6ec27f8d0ab7f3d1840f2fea4f
parentdebc420622f9ed56fd2f23d455f831a22cf5a256
image: fix race between mkits.sh and mkimage in .itb squashfs generation

With further investigation it was found a race in generating .itb images
that include a RootFS caused by the mkits.sh and the mkimage.

Due to the fact that mkits.sh generates a .pagesync image of the passed
rootfs, it can happen that, concurrently, mkimage can be called at the
same time mkits.sh is creating another .pagesync for the same rootfs.

This cause mkimage to use an half made rootfs.pagesync creating a
corrupted image.

To address this, also protect the mkimage with the same lock used for
mkits.sh preventing any kind of concurrent usage/generation of the
rootfs.pagesync blob

Fixes: 52cc9d82f113 ("kernel: rework Initramfs locking logic")
Link: https://github.com/openwrt/openwrt/pull/20492
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
(cherry picked from commit 3de1bbd5aeb542de9a4b20eff0f6bbf1767fd6b9)
include/image-commands.mk