]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netfilter: ebtables: fix a memory leak bug in compat
authorWenwen Wang <wenwen@cs.uga.edu>
Sat, 20 Jul 2019 12:22:45 +0000 (07:22 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Aug 2019 06:26:37 +0000 (08:26 +0200)
commitbdfb3b352767c98cefe6ca50ba4ed4b34d4aea20
tree7b7b2566d0838742e77dd3a34a8de09246d5300b
parent5bb56df55934237ae7a35299fb17f231a46e3e31
netfilter: ebtables: fix a memory leak bug in compat

[ Upstream commit 15a78ba1844a8e052c1226f930133de4cef4e7ad ]

In compat_do_replace(), a temporary buffer is allocated through vmalloc()
to hold entries copied from the user space. The buffer address is firstly
saved to 'newinfo->entries', and later on assigned to 'entries_tmp'. Then
the entries in this temporary buffer is copied to the internal kernel
structure through compat_copy_entries(). If this copy process fails,
compat_do_replace() should be terminated. However, the allocated temporary
buffer is not freed on this path, leading to a memory leak.

To fix the bug, free the buffer before returning from compat_do_replace().

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/bridge/netfilter/ebtables.c