]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
kselftest/arm64: signal: fix/refactor SVE vector length enumeration
authorAndre Przywara <andre.przywara@arm.com>
Wed, 21 Aug 2024 16:44:01 +0000 (17:44 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:28:51 +0000 (16:28 +0200)
commitbe158b7e6a46572cf23c1d93ff81a5b760cad9e9
tree222f6d95d42ddafc8aa2d6daa9a101907e89d240
parent288cbc505e2046638c615c36357cb78bc9fee1e0
kselftest/arm64: signal: fix/refactor SVE vector length enumeration

[ Upstream commit 5225b6562b9a7dc808d5a1e465aaf5e2ebb220cd ]

Currently a number of SVE/SME related tests have almost identical
functions to enumerate all supported vector lengths. However over time
the copy&pasted code has diverged, allowing some bugs to creep in:
- fake_sigreturn_sme_change_vl reports a failure, not a SKIP if only
  one vector length is supported (but the SVE version is fine)
- fake_sigreturn_sme_change_vl tries to set the SVE vector length, not
  the SME one (but the other SME tests are fine)
- za_no_regs keeps iterating forever if only one vector length is
  supported (but za_regs is correct)

Since those bugs seem to be mostly copy&paste ones, let's consolidate
the enumeration loop into one shared function, and just call that from
each test. That should fix the above bugs, and prevent similar issues
from happening again.

Fixes: 4963aeb35a9e ("kselftest/arm64: signal: Add SME signal handling tests")
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20240821164401.3598545-1-andre.przywara@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/arm64/signal/Makefile
tools/testing/selftests/arm64/signal/sve_helpers.c [new file with mode: 0644]
tools/testing/selftests/arm64/signal/sve_helpers.h [new file with mode: 0644]
tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_sme_change_vl.c
tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_sve_change_vl.c
tools/testing/selftests/arm64/signal/testcases/ssve_regs.c
tools/testing/selftests/arm64/signal/testcases/ssve_za_regs.c
tools/testing/selftests/arm64/signal/testcases/sve_regs.c
tools/testing/selftests/arm64/signal/testcases/za_no_regs.c
tools/testing/selftests/arm64/signal/testcases/za_regs.c