]> git.ipfire.org Git - thirdparty/linux.git/commit
btrfs: tests: fix root tree leak in btrfs_test_qgroups()
authorZilin Guan <zilin@seu.edu.cn>
Fri, 26 Dec 2025 11:30:22 +0000 (11:30 +0000)
committerDavid Sterba <dsterba@suse.com>
Fri, 9 Jan 2026 16:41:45 +0000 (17:41 +0100)
commitbe1c2e8afe3ac4a4f15a13f6844619c2cf47b1d1
tree2ee9d8e06cad863cd7221899d64a4cd354ddc365
parent1e1f2055ad5a7a5d548789b334a4473a7665c418
btrfs: tests: fix root tree leak in btrfs_test_qgroups()

If btrfs_insert_fs_root() fails, the tmp_root allocated by
btrfs_alloc_dummy_root() is leaked because its initial reference count
is not decremented.

Fix this by calling btrfs_put_root() unconditionally after
btrfs_insert_fs_root(). This ensures the local reference is always
dropped.

Also fix a copy-paste error in the error message where the subvolume
root insertion failure was incorrectly logged as "fs root".

Co-developed-by: Jianhao Xu <jianhao.xu@seu.edu.cn>
Signed-off-by: Jianhao Xu <jianhao.xu@seu.edu.cn>
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/tests/qgroup-tests.c