]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: q6apm-lpass-dai: close graph on prepare errors
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Thu, 13 Jun 2024 12:13:05 +0000 (13:13 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 14 Jun 2024 14:22:20 +0000 (15:22 +0100)
commitbe1fae62cf253a5b67526cee9fbc07689b97c125
tree198febde9decf5ede741259ce3d099bc8d9af1f5
parent8af49868e51ed1ba117b74728af12abe1eda82e5
ASoC: q6apm-lpass-dai: close graph on prepare errors

There is an issue around with error handling and graph management with
the exising code, none of the error paths close the graph, which result in
leaving the loaded graph in dsp, however the driver thinks otherwise.

This can have a nasty side effect specially when we try to load the same
graph to dsp, dsp returns error which leaves the board with no sound and
requires restart.

Fix this by properly closing the graph when we hit errors between
open and close.

Fixes: 30ad723b93ad ("ASoC: qdsp6: audioreach: add q6apm lpass dai support")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> # X13s
Link: https://lore.kernel.org/r/20240613-q6apm-fixes-v1-1-d88953675ab3@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/qdsp6/q6apm-lpass-dais.c