]> git.ipfire.org Git - thirdparty/libvirt.git/commit
process: wait longer on kill per assigned Hostdev
authorChristian Ehrhardt <christian.ehrhardt@canonical.com>
Thu, 2 Aug 2018 07:05:18 +0000 (09:05 +0200)
committerChristian Ehrhardt <christian.ehrhardt@canonical.com>
Tue, 21 Aug 2018 15:37:10 +0000 (17:37 +0200)
commitbe2ca0444728edd12a000653d3693d68a5c9102f
treea73d0c9afb44adca7951784065014945ca013884
parentc9247c8e26266ef3b841acecd69f8abd8cb26f6d
process: wait longer on kill per assigned Hostdev

It was found that in cases with host devices virProcessKillPainfully
might be able to send signal zero to the target PID for quite a while
with the process already being gone from /proc/<PID>.

That is due to cleanup and reset of devices which might include a
secondary bus reset that on top of the actions taken has a 1s delay
to let the bus settle. Due to that guests with plenty of Host devices
could easily exceed the default timeouts.

To solve that, this adds an extra delay of 2s per hostdev that is associated
to a VM.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
src/libvirt_private.syms
src/qemu/qemu_process.c
src/util/virprocess.c
src/util/virprocess.h