]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tty: Retry failed reopen if tty teardown in-progress
authorPeter Hurley <peter@hurleysoftware.com>
Sun, 10 Jan 2016 05:13:45 +0000 (21:13 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 19 Feb 2016 22:28:34 +0000 (14:28 -0800)
commitbe883527a34effc3c7d2d851593a587956d0a6d1
treec0c3dcc0b7ee1d7e6f5b8b8d050c3232521a90ad
parenta526e121e137bef3aea68a2491c7c48a4fd124f3
tty: Retry failed reopen if tty teardown in-progress

commit 7f22f6c935cda600660e623a411fe380015d28d9 upstream.

A small window exists where a tty reopen will observe the tty
just prior to imminent teardown (tty->count == 0); in this case, open()
returns EIO to userspace.

Instead, retry the open after checking for signals and yielding;
this interruptible retry loop allows teardown to commence and initialize
a new tty on retry. Never retry the BSD master pty reopen; there is no
guarantee the pty pair teardown is imminent since the slave file
descriptors may remain open indefinitely.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/tty_io.c