]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pgstat: fix subscription stats entry leak.
authorMasahiko Sawada <msawada@postgresql.org>
Wed, 5 Jul 2023 05:49:58 +0000 (14:49 +0900)
committerMasahiko Sawada <msawada@postgresql.org>
Wed, 5 Jul 2023 05:49:58 +0000 (14:49 +0900)
commitbe8cae7e2f03f35a049e2b1f1113860fea6d0212
tree1ea4bc60f0da35674ed202443a9438559bb15f82
parenteb27d3dc88879cb148ae0365394aae0ab84fa1a7
pgstat: fix subscription stats entry leak.

Commit 7b64e4b3 taught DropSubscription() to drop stats entry of
subscription that is not associated with a replication slot for apply
worker at DROP SUBSCRIPTION but missed covering the case where the
subscription is not associated with replication slots for both apply
worker and tablesync worker.

Also add a test to verify that the stats for slot-less subscription is
removed at DROP SUBSCRIPTION time.

Backpatch down to 15.

Author: Masahiko Sawada
Reviewed-by: Nathan Bossart, Hayato Kuroda, Melih Mutlu, Amit Kapila
Discussion: https://postgr.es/m/CAD21AoB71zkP7uPT7JDPsZcvp0749ExEQnOJxeNKPDFisHar+w@mail.gmail.com
Backpatch-through: 15
src/backend/commands/subscriptioncmds.c
src/test/subscription/t/026_stats.pl