]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
hv_netvsc: fix race of netvsc and VF register_netdevice
authorHaiyang Zhang <haiyangz@microsoft.com>
Sun, 19 Nov 2023 16:23:41 +0000 (08:23 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Dec 2023 07:48:02 +0000 (08:48 +0100)
commitbec3ae29381069a1209a4267cb4152628fbd5930
tree3130afd22ecba3d1a30fd4013e6bcf657021e648
parent69732d2151b581df7b4c12fccf07d6eb36446c08
hv_netvsc: fix race of netvsc and VF register_netdevice

[ Upstream commit d30fb712e52964f2cf9a9c14cf67078394044837 ]

The rtnl lock also needs to be held before rndis_filter_device_add()
which advertises nvsp_2_vsc_capability / sriov bit, and triggers
VF NIC offering and registering. If VF NIC finished register_netdev()
earlier it may cause name based config failure.

To fix this issue, move the call to rtnl_lock() before
rndis_filter_device_add(), so VF will be registered later than netvsc
/ synthetic NIC, and gets a name numbered (ethX) after netvsc.

Cc: stable@vger.kernel.org
Fixes: e04e7a7bbd4b ("hv_netvsc: Fix a deadlock by getting rtnl lock earlier in netvsc_probe()")
Reported-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/hyperv/netvsc_drv.c