]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
[3.13] gh-108172: do not override OS preferred browser if it is a super-string of...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 2 Sep 2024 11:18:27 +0000 (13:18 +0200)
committerGitHub <noreply@github.com>
Mon, 2 Sep 2024 11:18:27 +0000 (13:18 +0200)
commitbf0d8bb30197a10867e48814a1b0595d50e02695
tree546720322137c1a6aedbbae43fba245100803f8d
parent1af74fa652b40d5ce67875ebfefd2f5a1cc28a2f
[3.13] gh-108172: do not override OS preferred browser if it is a super-string of a known browser (GH-113011) (#123527)

gh-108172: do not override OS preferred browser if it is a super-string of a known browser (GH-113011)

When checking if the registering browser is the "OS preferred browser", do not use a substring search - that makes no sense: one can have a preferred browser that looks like a super-string of a known browser, e.g. "firefox-nightly" vs "firefox".

https://github.com/python/cpython/issues/108172 explains in more detail, and lays out a potential better future enhancement for this case of just using xdg-open.  We'll go with this for now.

---------

(cherry picked from commit 10bf615bab9f832971a098f0a42b0d617aea6993)

Co-authored-by: Oded Arbel <oded@geek.co.il>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Lib/webbrowser.py
Misc/NEWS.d/next/Library/2023-12-12-15-19-58.gh-issue-108172.KyDPuG.rst [new file with mode: 0644]