]> git.ipfire.org Git - thirdparty/haproxy.git/commit
[BUG] http: fix truncated responses on chunk encoding when size divides buffer size
authorWilly Tarreau <w@1wt.eu>
Wed, 17 Mar 2010 14:54:24 +0000 (15:54 +0100)
committerWilly Tarreau <w@1wt.eu>
Wed, 17 Mar 2010 14:54:24 +0000 (15:54 +0100)
commitbf3f1de5b58aa77c2a3da4e143d5a7b2f1056b53
tree9e96fc63db45209a699b13ba3e9d80595927264d
parent6315d914b6c0ac3a292cadea39cc4b1a21f416a0
[BUG] http: fix truncated responses on chunk encoding when size divides buffer size

Bernhard Krieger reported truncated HTTP responses in presence of some
specific chunk-encoded data, and kindly offered complete traces of the
issue which made it easy to reproduce it.

Those traces showed that the chunks were of exactly 8192 bytes, chunk
size and CRLF included, which was exactly half the size of the buffer.
In this situation, the function http_chunk_skip_crlf() could erroneously
try to parse a CRLF after the chunk believing there were more data
pending, because the number of bytes present in the buffer was considered
instead of the number of remaining bytes to be parsed.
src/proto_http.c