]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
leds: rgb: mt6370: Switch to device_for_each_child_node_scoped()
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Thu, 26 Sep 2024 23:21:09 +0000 (01:21 +0200)
committerLee Jones <lee@kernel.org>
Wed, 9 Oct 2024 14:19:22 +0000 (15:19 +0100)
commitbf3fba727695dcd1ac3f9d17d88845223f56c14f
treeb5b2af2be45d642216e2e3329501e4d14fd48bb3
parent48259638fe5986afe8ed2a49e35f0641d953c311
leds: rgb: mt6370: Switch to device_for_each_child_node_scoped()

Switch to device_for_each_child_node_scoped() to simplify the code by
removing the need for calls to fwnode_handle_put() in the error paths.

This also prevents possible memory leaks if new error paths are added
without the required call to fwnode_handle_put().

After switching to the scoped variant, there is no longer need for a
jump to 'fwnode_release', as an immediate return is possible. Given that
the loop is called in the probe function, and it already uses
dev_err_probe(), the common "dev_err() + return" has been updated as
well.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20240927-leds_device_for_each_child_node_scoped-v1-18-95c0614b38c8@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/rgb/leds-mt6370-rgb.c