]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: hamradio: 6pack: fix uninit-value in sixpack_receive_buf
authorMashiro Chen <mashiro.chen@mailbox.org>
Tue, 7 Apr 2026 17:31:01 +0000 (01:31 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 10 Apr 2026 22:25:59 +0000 (15:25 -0700)
commitbf9a38803b2626b01cc769aaf13485d8650f576f
tree49046825d57519aa761fe98110dacc2d2ed7f4dc
parent12ff2a4aee6c86746623d5aed24389dbf6dffded
net: hamradio: 6pack: fix uninit-value in sixpack_receive_buf

sixpack_receive_buf() does not properly skip bytes with TTY error flags.
The while loop iterates through the flags buffer but never advances the
data pointer (cp), and passes the original count (including error bytes)
to sixpack_decode(). This causes sixpack_decode() to process bytes that
should have been skipped due to TTY errors.  The TTY layer does not
guarantee that cp[i] holds a meaningful value when fp[i] is set, so
passing those positions to sixpack_decode() results in KMSAN reporting
an uninit-value read.

Fix this by processing bytes one at a time, advancing cp on each
iteration, and only passing valid (non-error) bytes to sixpack_decode().
This matches the pattern used by slip_receive_buf() and
mkiss_receive_buf() for the same purpose.

Reported-by: syzbot+ecdb8c9878a81eb21e54@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=ecdb8c9878a81eb21e54
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Mashiro Chen <mashiro.chen@mailbox.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260407173101.107352-1-mashiro.chen@mailbox.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/hamradio/6pack.c