]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
usb: gadget: Store endpoint pointer in usb_request
authorKuen-Han Tsai <khtsai@google.com>
Tue, 16 Sep 2025 08:21:32 +0000 (16:21 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Sep 2025 10:44:53 +0000 (12:44 +0200)
commitbfb1d99d969fe3b892db30848aeebfa19d21f57f
tree930018e3a346514def2a4b2d6569d57d7dc105ec
parent1b237f190eb3d36f52dffe07a40b5eb210280e00
usb: gadget: Store endpoint pointer in usb_request

Gadget function drivers often have goto-based error handling in their
bind paths, which can be bug-prone. Refactoring these paths to use
__free() scope-based cleanup is desirable, but currently blocked.

The blocker is that usb_ep_free_request(ep, req) requires two
parameters, while the __free() mechanism can only pass a pointer to the
request itself.

Store an endpoint pointer in the struct usb_request. The pointer is
populated centrally in usb_ep_alloc_request() on every successful
allocation, making the request object self-contained.

Signed-off-by: Kuen-Han Tsai <khtsai@google.com>
Link: https://lore.kernel.org/r/20250916-ready-v1-1-4997bf277548@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20250916-ready-v1-1-4997bf277548@google.com
drivers/usb/gadget/udc/core.c
include/linux/usb/gadget.h