]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-117303: Don't detach in `PyThreadState_DeleteCurrent()` (#117304)
authorSam Gross <colesbury@gmail.com>
Fri, 29 Mar 2024 22:58:08 +0000 (18:58 -0400)
committerGitHub <noreply@github.com>
Fri, 29 Mar 2024 22:58:08 +0000 (18:58 -0400)
commitbfc57d43d8766120ba0c8f3f6d7b2ac681a81d8a
tree33ad4298aa1f2532c876a08244e387a9e8cfb572
parent05e0b67a43c5c1778dc2643c8b7c12864e135999
gh-117303: Don't detach in `PyThreadState_DeleteCurrent()` (#117304)

This fixes a crash in `test_threading.test_reinit_tls_after_fork()` when
running with the GIL disabled. We already properly handle the case where
the thread state is `_Py_THREAD_ATTACHED` in `tstate_delete_common()` --
we just need to remove an assertion.

Keeping the thread attached means that a stop-the-world pause, such as
for a `fork()`, won't commence until we remove our thread state from the
interpreter's linked list. This prevents a crash when the child process
tries to clean up the dead thread states.
Python/pystate.c